Skip to content

Fix padding of elements in address bar of webview

Mushaheed Syed requested to merge mushaheed#address_bar_design into main

I've fixed padding as per figma designs in the address bar. Have also fixed the following points:

  • Updated the padlock icon in shown before the url and fixed background color behind the system navigation bar overlay.
  • Fixed constant top padding on webview screen.
  • Fixed progress bar's visibility when page is 100% loaded (it shouldn't be visible when page is loaded i.e progress == 1.0)

Notes after fixing padding issue

  • This is how webview screen looks for Netflix
Webview Screen for Netflix
  • This shows the padding & boundaries of components. Notice the top and bottom padding on the screen, this is received from media query and is not a fixed value now (the top padding was previously a constant value 30. We couldn't have fixed webview bar padding properly without modifying this constant padding.
Webview Screen with Boundaries
Edited by Mushaheed Syed

Merge request reports